Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1383] bugfix: fix exception mapper type from registered features #1384

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

lprimak
Copy link
Contributor

@lprimak lprimak commented Mar 23, 2024

Changed registration of UnauthenticatedException.class to UnauthenticatedExceptionMapper.class Jax-rs feature context.
fixes #1383

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak requested review from bmarwell and fpapon March 23, 2024 16:56
@lprimak lprimak self-assigned this Mar 23, 2024
@lprimak lprimak added java Pull requests that update Java code jakartaee Jakarta EE labels Mar 23, 2024
@lprimak lprimak added this to the 2.0.1 milestone Mar 23, 2024
@lprimak lprimak changed the title bugfix: remove exception from registered features [#1383] bugfix: remove exception from registered features Mar 23, 2024
@lprimak lprimak force-pushed the remove-exception-from-jaxrs-context branch from 486c611 to 769c2fc Compare March 23, 2024 17:10
@lprimak lprimak force-pushed the remove-exception-from-jaxrs-context branch from 769c2fc to bd04d14 Compare March 23, 2024 19:45
@lprimak lprimak force-pushed the remove-exception-from-jaxrs-context branch from bd04d14 to e1d4560 Compare March 23, 2024 19:56
@lprimak lprimak requested a review from zenios March 23, 2024 20:05
Copy link

@zenios zenios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lprimak good catch!

@lprimak lprimak changed the title [#1383] bugfix: remove exception from registered features [#1383] bugfix: fix exception mapper type from registered features Mar 24, 2024
@lprimak
Copy link
Contributor Author

lprimak commented Mar 24, 2024

Credit where credit is due, @zenios discovered this.

@fpapon
Copy link
Member

fpapon commented Mar 25, 2024

@zenios good catch and thank you for your contribution!

@lprimak lprimak merged commit e577150 into apache:main Mar 25, 2024
22 checks passed
@lprimak lprimak deleted the remove-exception-from-jaxrs-context branch March 29, 2024 01:33
Copy link
Contributor

@bmarwell bmarwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, how was this not discovered before? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jakartaee Jakarta EE java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong class registered in jaxrs feature
4 participants