-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1048: Solved base64 problem with remember me cookie. #1049
#1048: Solved base64 problem with remember me cookie. #1049
Conversation
Thanks for your contribution!
|
It looks like the failing test tested the wrong situation. I split it in two tests: one that discovers a Base64 string that is invalid and another one that discovers the Base64 string does not contain encrypted information. |
@JaapD thanks for your contribution! Can you squash the commits please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits please?
Make tests to work with an unvalid Base64 string and a Base64 string without encrypted content. 1048: Solved base64 problem with remember me cookie.
@fpapon I squashed the commits. I struggled a bit with squashing, but I think it is OK now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue 1048
The cookie value sometimes got too much '=' characters at the end.
I created a test to make the method fail, then I solved the problem. That fixed the test and made the RememberMe work again.