-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default extPlugin path to relative path. #5632
Open
initialdmg
wants to merge
56
commits into
apache:master
Choose a base branch
from
initialdmg:fix-ext-plugin-path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−5
Open
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
2ee61d0
set default extPlugin path to relative path.
initialdmg ad986c8
Merge branch 'master' into fix-ext-plugin-path
Aias00 d875a8b
Merge branch 'master' into fix-ext-plugin-path
Aias00 b6da1cb
Merge branch 'master' into fix-ext-plugin-path
Aias00 70cc777
Merge branch 'master' into fix-ext-plugin-path
Aias00 1654e78
Merge branch 'master' into fix-ext-plugin-path
Aias00 bd11e0b
Merge branch 'master' into fix-ext-plugin-path
Aias00 2449607
Merge branch 'master' into fix-ext-plugin-path
Aias00 66095d0
Merge branch 'master' into fix-ext-plugin-path
Aias00 2ccf980
Merge branch 'master' into fix-ext-plugin-path
Aias00 2d06f9b
Merge branch 'master' into fix-ext-plugin-path
Aias00 629e3a6
Merge branch 'master' into fix-ext-plugin-path
Aias00 880957e
Merge branch 'master' into fix-ext-plugin-path
Aias00 32061c2
Merge branch 'master' into fix-ext-plugin-path
Aias00 f5d1436
Merge branch 'master' into fix-ext-plugin-path
Aias00 ea57bb5
Merge branch 'master' into fix-ext-plugin-path
Aias00 0ca5ace
Merge branch 'master' into fix-ext-plugin-path
Aias00 02d7d26
Merge branch 'master' into fix-ext-plugin-path
Aias00 5c68c1b
Merge branch 'master' into fix-ext-plugin-path
Aias00 490cab9
Merge branch 'master' into fix-ext-plugin-path
Aias00 80e19fa
Merge branch 'master' into fix-ext-plugin-path
Aias00 e3cda82
Merge branch 'master' into fix-ext-plugin-path
Aias00 fcb5776
Merge branch 'master' into fix-ext-plugin-path
yu199195 a797878
Merge branch 'master' into fix-ext-plugin-path
Aias00 37216a5
Merge branch 'master' into fix-ext-plugin-path
Aias00 e3e9029
Merge branch 'master' into fix-ext-plugin-path
Aias00 4f45e94
Merge branch 'master' into fix-ext-plugin-path
Aias00 3105042
Merge branch 'master' into fix-ext-plugin-path
Aias00 a06d195
Merge branch 'master' into fix-ext-plugin-path
Aias00 e446f07
Merge branch 'master' into fix-ext-plugin-path
Aias00 625cac6
Merge branch 'master' into fix-ext-plugin-path
Aias00 2d0de2b
Merge branch 'master' into fix-ext-plugin-path
Aias00 09d3c91
Merge branch 'master' into fix-ext-plugin-path
Aias00 4aa1c8f
Merge branch 'master' into fix-ext-plugin-path
Aias00 51342f8
Merge branch 'master' into fix-ext-plugin-path
Aias00 a2bc0eb
Merge branch 'master' into fix-ext-plugin-path
Aias00 a9dcd28
Merge branch 'master' into fix-ext-plugin-path
Aias00 fe58ad2
Merge branch 'master' into fix-ext-plugin-path
Aias00 0831de7
Merge branch 'master' into fix-ext-plugin-path
Aias00 7640a40
Merge branch 'master' into fix-ext-plugin-path
Aias00 de4764b
Merge branch 'master' into fix-ext-plugin-path
Aias00 19f74c9
Merge branch 'master' into fix-ext-plugin-path
Aias00 4406e1f
Merge branch 'master' into fix-ext-plugin-path
Aias00 8c13486
Merge branch 'master' into fix-ext-plugin-path
Aias00 c6ae5e5
Merge branch 'master' into fix-ext-plugin-path
Aias00 a880ed6
Merge branch 'master' into fix-ext-plugin-path
Aias00 ef91266
Merge branch 'master' into fix-ext-plugin-path
Aias00 232bfb0
Merge branch 'master' into fix-ext-plugin-path
Aias00 4240640
Merge branch 'master' into fix-ext-plugin-path
Aias00 6bd37a3
Merge branch 'master' into fix-ext-plugin-path
Aias00 c0a0594
Merge branch 'master' into fix-ext-plugin-path
Aias00 ca1202c
Merge branch 'master' into fix-ext-plugin-path
Aias00 135f8b4
Merge branch 'master' into fix-ext-plugin-path
Aias00 286287d
Merge branch 'master' into fix-ext-plugin-path
Aias00 80961ea
Merge branch 'master' into fix-ext-plugin-path
Aias00 d6cb748
Merge branch 'master' into fix-ext-plugin-path
Aias00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't use '/ ' at the beginning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The absolute path of
/ext-lib/
is not in the deployment directory. On Linux, it's just pointing to the/ext-lib
folder. On Windows it is in the root of the deployment driver. A log point added to confirm this. We can find this in test case too:shenyu/shenyu-web/src/test/java/org/apache/shenyu/web/loader/ShenyuPluginPathBuilderTest.java
Lines 42 to 49 in 1f5b5cd