Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for soul-admin #500

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Add test cases for soul-admin #500

merged 1 commit into from
Dec 4, 2020

Conversation

dengliming
Copy link
Member

@dengliming dengliming commented Dec 3, 2020

添加一些admin测试的样例, 目前mapper访问数据库测试暂时使用H2, 后面如果使用到mysql特性无法兼容则直接使用testcontainer

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed mvn clean install -Dmaven.javadoc.skip=true.

@codecov-io
Copy link

Codecov Report

Merging #500 (ac3a543) into master (92b7584) will decrease coverage by 1.37%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #500      +/-   ##
============================================
- Coverage     15.08%   13.70%   -1.38%     
- Complexity      115      252     +137     
============================================
  Files           124      244     +120     
  Lines          2340     4975    +2635     
  Branches        274      463     +189     
============================================
+ Hits            353      682     +329     
- Misses         1927     4219    +2292     
- Partials         60       74      +14     
Impacted Files Coverage Δ Complexity Δ
...g/dromara/soul/admin/dto/SpringMvcRegisterDTO.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...n/java/org/dromara/soul/admin/dto/SelectorDTO.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...rg/dromara/soul/admin/utils/SoulResultMessage.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...in/service/impl/SoulClientRegisterServiceImpl.java 5.07% <0.00%> (ø) 1.00% <0.00%> (?%)
.../java/org/dromara/soul/admin/entity/AppAuthDO.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...oul/admin/listener/DataChangedEventDispatcher.java 28.57% <0.00%> (ø) 2.00% <0.00%> (?%)
...ain/java/org/dromara/soul/admin/vo/SoulDictVO.java 94.73% <0.00%> (ø) 13.00% <0.00%> (?%)
...n/java/org/dromara/soul/admin/entity/PluginDO.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...romara/soul/admin/config/SwaggerConfiguration.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...ain/java/org/dromara/soul/admin/vo/AuthPathVO.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b7584...ac3a543. Read the comment docs.

@yu199195 yu199195 self-requested a review December 4, 2020 02:47
@yu199195 yu199195 added this to the 2.3.0 milestone Dec 4, 2020
@yu199195 yu199195 merged commit ed922a2 into apache:master Dec 4, 2020
@dengliming dengliming deleted the admin_testcases branch December 5, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants