Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the handling for ShowTablesMergedResult. #960

Merged
merged 6 commits into from
Jun 25, 2018
Merged

Modify the handling for ShowTablesMergedResult. #960

merged 6 commits into from
Jun 25, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #954 .

Changes proposed in this pull request:

  • Passthrough ShardingMeta info MergeEngine.
  • Modify the handling for ShowTablesMergedResult.
  • Modify some of test cases.

@codecov-io
Copy link

codecov-io commented Jun 25, 2018

Codecov Report

Merging #960 into dev will increase coverage by 0.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #960      +/-   ##
==========================================
+ Coverage   52.73%   52.75%   +0.01%     
==========================================
  Files         579      579              
  Lines       12120    12136      +16     
  Branches     1901     1905       +4     
==========================================
+ Hits         6392     6402      +10     
- Misses       5361     5364       +3     
- Partials      367      370       +3
Impacted Files Coverage Δ
...proxy/backend/common/SQLPacketsBackendHandler.java 0% <0%> (ø) ⬆️
...shardingsphere/core/metadata/ShardingMetaData.java 2.22% <0%> (-0.28%) ⬇️
...backend/common/StatementExecuteBackendHandler.java 0% <0%> (ø) ⬆️
...proxy/backend/common/SQLExecuteBackendHandler.java 0% <0%> (ø) ⬆️
...shardingsphere/core/merger/MergeEngineFactory.java 100% <100%> (ø) ⬆️
...re/core/jdbc/core/statement/ShardingStatement.java 80.67% <100%> (+0.33%) ⬆️
...shardingsphere/core/merger/dal/DALMergeEngine.java 100% <100%> (ø) ⬆️
...jdbc/core/statement/ShardingPreparedStatement.java 83.68% <100%> (+0.23%) ⬆️
...e/core/merger/dal/show/ShowTablesMergedResult.java 87.5% <40%> (-8.93%) ⬇️
...OrchestrationMasterSlaveDataSourceFactoryBean.java 66.66% <0%> (-11.12%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b4a463...1a103b4. Read the comment docs.

@terrymanu terrymanu merged commit 8e27446 into apache:dev Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants