Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3555, carry PR#5178 to dev-4.x #5731

Merged
merged 1 commit into from
May 21, 2020
Merged

#3555, carry PR#5178 to dev-4.x #5731

merged 1 commit into from
May 21, 2020

Conversation

tuohai666
Copy link
Member

Fixes #3555.

@codecov-commenter
Copy link

Codecov Report

Merging #5731 into dev-4.x will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             dev-4.x    #5731      +/-   ##
=============================================
- Coverage      53.69%   53.67%   -0.02%     
+ Complexity       391      387       -4     
=============================================
  Files           1147     1147              
  Lines          20446    20446              
  Branches        3722     3722              
=============================================
- Hits           10979    10975       -4     
- Misses          8781     8785       +4     
  Partials         686      686              
Impacted Files Coverage Δ Complexity Δ
...ry/binary/execute/MySQLComStmtExecuteExecutor.java 22.85% <0.00%> (-2.86%) 0.00 <0.00> (-1.00)
.../query/text/query/MySQLComQueryPacketExecutor.java 17.94% <0.00%> (-2.57%) 0.00 <0.00> (-1.00)
...gresql/command/PostgreSQLCommandExecuteEngine.java 9.67% <0.00%> (ø) 0.00 <0.00> (ø)
...d/query/binary/bind/PostgreSQLComBindExecutor.java 25.58% <0.00%> (-2.33%) 0.00 <0.00> (-1.00)
...command/query/text/PostgreSQLComQueryExecutor.java 22.58% <0.00%> (-3.23%) 0.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3aa8e1...f23aab2. Read the comment docs.

@terrymanu terrymanu self-requested a review May 21, 2020 10:16
@terrymanu terrymanu merged commit 8ad915c into apache:dev-4.x May 21, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11971

  • 1 of 5 (20.0%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.092%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java 0 1 0.0%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java 0 1 0.0%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/bind/PostgreSQLComBindExecutor.java 0 1 0.0%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/text/PostgreSQLComQueryExecutor.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/execute/MySQLComStmtExecuteExecutor.java 1 28.57%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/text/query/MySQLComQueryPacketExecutor.java 1 23.08%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/binary/bind/PostgreSQLComBindExecutor.java 1 39.53%
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/postgresql/command/query/text/PostgreSQLComQueryExecutor.java 1 29.03%
Totals Coverage Status
Change from base Build 11961: -0.02%
Covered Lines: 11673
Relevant Lines: 20446

💛 - Coveralls

@tuohai666 tuohai666 deleted the carry_5178 branch May 21, 2020 10:43
@kimmking kimmking mentioned this pull request Jun 2, 2020
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants