Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #544.Add additional-spring-configuration-metadata.json and spring… #547

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

top-bettercode
Copy link
Contributor

Add additional-spring-configuration-metadata.json and spring-boot-configuration-processor optional dependency.

Fixes #544.

Changes proposed in this pull request:

  • Add additional-spring-configuration-metadata.json
  • Add spring-boot-configuration-processor optional dependency.

…spring-boot-configuration-processor optional dependency.
@codecov-io
Copy link

Codecov Report

Merging #547 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #547      +/-   ##
=========================================
+ Coverage   79.47%   79.5%   +0.02%     
=========================================
  Files         380     380              
  Lines        7303    7303              
  Branches     1162    1162              
=========================================
+ Hits         5804    5806       +2     
+ Misses       1211    1207       -4     
- Partials      288     290       +2
Impacted Files Coverage Δ
...ternal/state/instance/InstanceListenerManager.java 37.93% <0%> (+3.44%) ⬆️
.../internal/config/ConfigurationListenerManager.java 72.41% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d7391...e4f8b3c. Read the comment docs.

@haocao haocao merged commit 6e6b044 into apache:dev Jan 11, 2018
@haocao
Copy link
Member

haocao commented Jan 15, 2018

Thanks for your contribution, but we also need wildcard prompt which like sharding.jdbc.datasource.ds_slave_1.type, ds_slave_1 is a dynamic property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants