Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3556, affect rows is always zero when using sharding-proxy postgresq… #5194

Merged
merged 1 commit into from
Apr 15, 2020
Merged

#3556, affect rows is always zero when using sharding-proxy postgresq… #5194

merged 1 commit into from
Apr 15, 2020

Conversation

tuohai666
Copy link
Member

…l mode

Fixes #3556.

@codecov-io
Copy link

Codecov Report

Merging #5194 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5194      +/-   ##
============================================
- Coverage     54.18%   54.09%   -0.09%     
  Complexity      406      406              
============================================
  Files          1158     1158              
  Lines         20555    20581      +26     
  Branches       3705     3705              
============================================
- Hits          11137    11134       -3     
- Misses         8727     8755      +28     
- Partials        691      692       +1     
Impacted Files Coverage Δ Complexity Δ
.../communication/jdbc/execute/JDBCExecuteEngine.java 22.22% <0.00%> (-9.36%) 0.00 <0.00> (ø)
...gproxy/backend/response/update/UpdateResponse.java 40.00% <ø> (ø) 0.00 <0.00> (ø)
...d/query/binary/bind/PostgreSQLComBindExecutor.java 25.58% <ø> (-2.33%) 0.00 <0.00> (-1.00)
...command/query/text/PostgreSQLComQueryExecutor.java 22.58% <ø> (-3.23%) 0.00 <0.00> (-1.00)
...acket/generic/PostgreSQLCommandCompletePacket.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/factorybean/KeyGenerateAlgorithmFactoryBean.java 90.90% <0.00%> (-9.10%) 1.00% <0.00%> (ø%)
...phere/shardingjdbc/executor/StatementExecutor.java 80.85% <0.00%> (-6.11%) 0.00% <0.00%> (ø%)
...ardingjdbc/executor/PreparedStatementExecutor.java 76.19% <0.00%> (-3.18%) 0.00% <0.00%> (ø%)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e985dba...9c47764. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11066

  • 0 of 19 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 57.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
shardingsphere-database-protocol/shardingsphere-database-protocol-postgresql/src/main/java/org/apache/shardingsphere/database/protocol/postgresql/packet/generic/PostgreSQLCommandCompletePacket.java 0 9 0.0%
sharding-proxy/sharding-proxy-backend/src/main/java/org/apache/shardingsphere/shardingproxy/backend/communication/jdbc/execute/JDBCExecuteEngine.java 0 10 0.0%
Totals Coverage Status
Change from base Build 11064: -0.03%
Covered Lines: 11839
Relevant Lines: 20581

💛 - Coveralls

@terrymanu terrymanu self-requested a review April 15, 2020 08:03
@terrymanu terrymanu merged commit 5560b57 into apache:master Apr 15, 2020
@tuohai666 tuohai666 deleted the issue-3556 branch April 15, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Proxy) Response num of update is Zero for postgres JDBC client
4 participants