Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Multimap and CaseInsensitiveString to replace CaseInsensitiveMap for supporting mysql multi table join with same table alias #33303

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Oct 18, 2024

Fixes #33302.

Changes proposed in this pull request:

  • Use Multimap and CaseInsensitiveString to replace CaseInsensitiveMap for supporting mysql multi table join with same table alias

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member Author

image

@FlyingZC FlyingZC merged commit 044e049 into apache:master Oct 18, 2024
141 checks passed
@strongduanmu strongduanmu deleted the dev-1018 branch October 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown column in 'on clause' exception occurs when mysql join have duplicate table aliases
2 participants