Added Unit test for ExpressionSegmentBinder #28883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@strongduanmu - Kindly review and merge this PR. |
strongduanmu
requested changes
Oct 28, 2023
...a/org/apache/shardingsphere/infra/binder/segment/expression/ExpressionSegmentBinderTest.java
Outdated
Show resolved
Hide resolved
...a/org/apache/shardingsphere/infra/binder/segment/expression/ExpressionSegmentBinderTest.java
Outdated
Show resolved
Hide resolved
...a/org/apache/shardingsphere/infra/binder/segment/expression/ExpressionSegmentBinderTest.java
Outdated
Show resolved
Hide resolved
|
@strongduanmu - Kindly re-review and merge it. Thanks |
|
@strongduanmu - Is there any review pending? |
strongduanmu
requested changes
Nov 1, 2023
| SQLStatementBinderContext statementBinderContext = new SQLStatementBinderContext(new ShardingSphereMetaData(), "db", new MockedDatabaseType(), Collections.emptyList()); | ||
| ExpressionSegment actual = ExpressionSegmentBinder.bind(binaryOperationExpression, SegmentType.INSERT_COLUMNS, statementBinderContext, Collections.emptyMap(), Collections.emptyMap()); | ||
| assertTrue(actual instanceof BinaryOperationExpression); | ||
| assertThat(binaryOperationExpression.getLeft(), is(((BinaryOperationExpression) actual).getLeft())); |
There was a problem hiding this comment.
It looks like this logic is wrong, and the segment that passes through bind will be regenerated. Whether you can assert the actual type and instance, the type should be same, and instance is different.
There was a problem hiding this comment.
Hi @Gowrishankar04, can you take a look at this recommend?
|
Since this pr has long time no reponse, I will close it. You are welcome to submit another PR based on comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28538.
Changes proposed in this pull request:
Added Unit test for ExpressionSegmentBinder
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.