-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leaf snowflake key generator and related functions. #2828
Conversation
@tristaZero.During CI building, the error happened with message "The command "travis_wait 30 mvn install --quiet" failed and exited with 137 during ." Is there anything wrong in the Travis CI system? |
Still running (30 of 30): mvn install --quiet
Timeout (30 minutes) reached. Terminating "mvn install --quiet" It looks like CI check timed out. I think you should try it again. |
int taskNumber = threadNumber << 2; | ||
for (int i = 0; i < taskNumber; i++) { | ||
actual.add(executor.submit(new Callable<Comparable<?>>() { | ||
@Override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add blank line
@@ -142,12 +138,11 @@ public void assertGenerateKeyWithDefaultStep() { | |||
} | |||
}).get()); | |||
} | |||
assertThat(actual.size(), is(taskNumber)); | |||
assertThat(actual.size(), CoreMatchers.is(taskNumber)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use import static if you want to use is() for asserting.
Changes proposed in this pull request:
Add LeafSnowflakeKeyGenerator class and TimeService class.
Add LeafSnowflakeKeyGeneratorTest class and FixedTimeService class.