Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate placeHolders to handle ItemsToken, LimitRowCountToken and so on for rewriting #2317

Merged
merged 19 commits into from
May 5, 2019

Conversation

tristaZero
Copy link
Contributor

Fixes #2275.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7904

  • 44 of 51 (86.27%) changed or added relevant lines in 5 files are covered.
  • 103 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 55.006%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/placeholder/SelectItemsPlaceholder.java 9 10 90.0%
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/SQLRewriteEngine.java 19 25 76.0%
Files with Coverage Reduction New Missed Lines %
sharding-core/sharding-core-rewrite/src/main/java/org/apache/shardingsphere/core/rewrite/SQLRewriteEngine.java 103 41.98%
Totals Coverage Status
Change from base Build 7903: -0.6%
Covered Lines: 8648
Relevant Lines: 15722

💛 - Coveralls

@terrymanu terrymanu added this to the 4.0.0.M2 milestone May 5, 2019
@terrymanu terrymanu merged commit db9dc06 into apache:dev May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconstruct rewriting module
3 participants