Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2253 bug fixes #2264

Merged
merged 3 commits into from
Apr 25, 2019
Merged

#2253 bug fixes #2264

merged 3 commits into from
Apr 25, 2019

Conversation

codefairy08
Copy link
Contributor

Fixes #ISSUSE_ID.

Changes proposed in this pull request:

@terrymanu terrymanu added this to the 4.0.0.M2 milestone Apr 25, 2019
@terrymanu terrymanu merged commit c132176 into apache:dev Apr 25, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7773

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0007%) to 55.194%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-core/sharding-core-optimize/src/main/java/org/apache/shardingsphere/core/optimize/result/insert/InsertOptimizeResultUnit.java 1 2 50.0%
sharding-core/sharding-core-parse/sharding-core-parse-common/src/main/java/org/apache/shardingsphere/core/parse/antlr/sql/segment/dml/expr/LiteralExpressionSegment.java 0 1 0.0%
Totals Coverage Status
Change from base Build 7772: -0.0007%
Covered Lines: 8729
Relevant Lines: 15815
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0-RC2
Development

Successfully merging this pull request may close these issues.
3 participants
@codefairy08 @coveralls @terrymanu