Support distributed transactions across multiple logical database(#19… #20114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20114 +/- ##
============================================
+ Coverage 60.54% 60.96% +0.42%
+ Complexity 2422 2418 -4
============================================
Files 3874 3873 -1
Lines 54796 54442 -354
Branches 7679 7626 -53
============================================
+ Hits 33176 33191 +15
+ Misses 18761 18390 -371
- Partials 2859 2861 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
strongduanmu
requested changes
Aug 13, 2022
I will check. |
strongduanmu
requested changes
Aug 13, 2022
| @@ -34,8 +35,10 @@ public final class ResourceDataSource { | |||
| private final DataSource dataSource; | |||
|
|
|||
| public ResourceDataSource(final String originalName, final DataSource dataSource) { | |||
| final String[] databaseAndDataSourceName = originalName.split("\\."); | |||
| @@ -46,6 +48,7 @@ public ConnectionTransaction(final String databaseName, final TransactionRule ru | |||
| } | |||
|
|
|||
| public ConnectionTransaction(final String databaseName, final TransactionType transactionType, final TransactionRule rule) { | |||
| this.databaseName = databaseName; | |||
There was a problem hiding this comment.
Should databaseName be extracted from SQL?
strongduanmu
approved these changes
Aug 16, 2022
TeslaCN
added a commit
to TeslaCN/shardingsphere
that referenced
this pull request
Aug 16, 2022
strongduanmu
pushed a commit
that referenced
this pull request
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19894.
Changes proposed in this pull request:
use xx_dbin transaction