Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for Proxy and fix some bugs #1081

Merged
merged 74 commits into from
Aug 1, 2018
Merged

Add test cases for Proxy and fix some bugs #1081

merged 74 commits into from
Aug 1, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #601 .

Changes proposed in this pull request:

  • Add test cases for Proxy
  • modify ShardingDataSourceMetaData to final and change some test cases.
  • Add more check items for orchestration to load
  • Add default dataSource for show creat table merge result.

…o dev

# Conflicts:
#	sharding-core/src/main/java/io/shardingsphere/core/metadata/table/ShardingTableMetaData.java
…o dev

# Conflicts:
#	sharding-core/src/main/java/io/shardingsphere/core/metadata/table/ShardingTableMetaData.java
@codecov-io
Copy link

Codecov Report

Merging #1081 into dev will increase coverage by 1.1%.
The diff coverage is 32.6%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #1081     +/-   ##
=========================================
+ Coverage   56.02%   57.12%   +1.1%     
=========================================
  Files         636      636             
  Lines       12564    12572      +8     
  Branches     2014     2021      +7     
=========================================
+ Hits         7039     7182    +143     
+ Misses       5080     4938    -142     
- Partials      445      452      +7
Impacted Files Coverage Δ
...etadata/datasource/ShardingDataSourceMetaData.java 100% <ø> (ø) ⬆️
...c/main/java/io/shardingsphere/proxy/Bootstrap.java 0% <0%> (ø) ⬆️
...e/metadata/table/executor/TableMetaDataLoader.java 0% <0%> (ø) ⬆️
...stration/internal/config/ConfigurationService.java 30.76% <0%> (-2.18%) ⬇️
...e/routing/type/standard/StandardRoutingEngine.java 0% <0%> (ø) ⬆️
...ng/type/broadcast/TableBroadcastRoutingEngine.java 89.47% <100%> (ø) ⬆️
.../core/jdbc/core/connection/ShardingConnection.java 82.75% <100%> (ø) ⬆️
...java/io/shardingsphere/core/rule/ShardingRule.java 83.82% <55.55%> (-2.34%) ⬇️
...e/merger/dal/show/ShowCreateTableMergedResult.java 93.75% <80%> (-0.19%) ⬇️
...OrchestrationMasterSlaveDataSourceFactoryBean.java 66.66% <0%> (-11.12%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c778526...147c43c. Read the comment docs.

@terrymanu terrymanu merged commit 66f1d75 into apache:dev Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants