Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLLogger should have a junit test #2126

Closed
betterjava opened this issue Mar 28, 2019 · 2 comments
Closed

SQLLogger should have a junit test #2126

betterjava opened this issue Mar 28, 2019 · 2 comments
Assignees
@betterjava
Labels
status: volunteer wanted type: enhancement

Comments

@betterjava
Copy link
Member

Feature Request

For English only, other languages will not accept.

Please pay attention on issues you submitted, because we maybe need more details.
If no response more than 7 days and we cannot make decision by current information, we will close it.

Please answer these questions before submitting your issue. Thanks!

Is your feature request related to a problem?

No.

Describe the feature you would like.

SQLLogger should have a junit test.
@betterjava
Copy link
Member Author

I am working on it.

@betterjava betterjava mentioned this issue Mar 28, 2019
Closed
@terrymanu
Copy link
Member

terrymanu commented Mar 28, 2019 •
edited
Loading

I added some code review comments on your pr

@betterjava betterjava mentioned this issue Mar 30, 2019
Merged
terrymanu added a commit that referenced this issue Apr 1, 2019
@terrymanu
Merge pull request #2139 from betterjava/logtest
9bb141e 
#2126 add SQLLoggerTest
@Harper0122 Harper0122 mentioned this issue Apr 1, 2019
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@betterjava betterjava

Labels
status: volunteer wanted type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@betterjava @terrymanu