-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor parameter definition of DistSQL for feature db-discovery (#2…
…0206) * Refactor parameter definition of DistSQL for feature db-discovery * update doc of DistSQL for feature db-discovery * fix shardingsphere-parser-test fail * update docs
- Loading branch information
1 parent
b6fcaeb
commit 60610c6
Showing
11 changed files
with
160 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
...va/org/apache/shardingsphere/dbdiscovery/distsql/parser/DatabaseDiscoveryDistSQLTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.shardingsphere.dbdiscovery.distsql.parser; | ||
|
|
||
| import static org.hamcrest.CoreMatchers.equalTo; | ||
| import static org.hamcrest.CoreMatchers.is; | ||
| import static org.junit.Assert.assertThat; | ||
|
|
||
| import lombok.SneakyThrows; | ||
| import org.antlr.v4.runtime.tree.ParseTreeVisitor; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.facade.DatabaseDiscoveryDistSQLStatementParserFacade; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.segment.DatabaseDiscoveryDefinitionSegment; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.segment.DatabaseDiscoveryProviderAlgorithmSegment; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.statement.AlterDatabaseDiscoveryRuleStatement; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.statement.AlterDatabaseDiscoveryTypeStatement; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.statement.CreateDatabaseDiscoveryRuleStatement; | ||
| import org.apache.shardingsphere.dbdiscovery.distsql.parser.statement.CreateDatabaseDiscoveryTypeStatement; | ||
| import org.apache.shardingsphere.distsql.parser.core.featured.FeaturedDistSQLStatementParserFacadeFactory; | ||
| import org.apache.shardingsphere.distsql.parser.statement.DistSQLStatement; | ||
| import org.apache.shardingsphere.sql.parser.api.visitor.SQLVisitor; | ||
| import org.apache.shardingsphere.sql.parser.core.ParseASTNode; | ||
| import org.apache.shardingsphere.sql.parser.core.SQLParserFactory; | ||
| import org.junit.Test; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.Iterator; | ||
| import java.util.Properties; | ||
|
|
||
| public class DatabaseDiscoveryDistSQLTest { | ||
|
|
||
| @Test | ||
| public void assertCreateDatabaseDiscoveryRule() { | ||
| String sql = "CREATE DB_DISCOVERY RULE db_discovery_group_0 (" | ||
| + "RESOURCES(ds_0, ds_1), TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))," | ||
| + "HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')))"; | ||
|
|
||
| CreateDatabaseDiscoveryRuleStatement distSQLStatement = (CreateDatabaseDiscoveryRuleStatement) getDistSQLStatement(sql); | ||
| assertThat(distSQLStatement.getRules().size(), is(1)); | ||
| assertDiscoverySegment((DatabaseDiscoveryDefinitionSegment) distSQLStatement.getRules().iterator().next()); | ||
| } | ||
|
|
||
| @Test | ||
| public void assertAlterDatabaseDiscoveryRule() { | ||
| String sql = "ALTER DB_DISCOVERY RULE db_discovery_group_0 (" | ||
| + "RESOURCES(ds_0, ds_1), TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))," | ||
| + "HEARTBEAT(PROPERTIES('keep-alive-cron'='0/5 * * * * ?')))"; | ||
| AlterDatabaseDiscoveryRuleStatement distSQLStatement = (AlterDatabaseDiscoveryRuleStatement) getDistSQLStatement(sql); | ||
| assertThat(distSQLStatement.getRules().size(), is(1)); | ||
| assertDiscoverySegment((DatabaseDiscoveryDefinitionSegment) distSQLStatement.getRules().iterator().next()); | ||
| } | ||
|
|
||
| @Test | ||
| public void assertCreateDatabaseDiscoveryType() { | ||
| String sql = "CREATE DB_DISCOVERY TYPE primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),primary_replica_ds_mgr_2(TYPE(NAME='mgr'))"; | ||
| CreateDatabaseDiscoveryTypeStatement distSQLStatement = (CreateDatabaseDiscoveryTypeStatement) getDistSQLStatement(sql); | ||
| assertThat(distSQLStatement.getProviders().size(), is(2)); | ||
| assertAlgorithmSegment(distSQLStatement.getProviders().iterator()); | ||
| } | ||
|
|
||
| @Test | ||
| public void assertAlterDatabaseDiscoveryType() { | ||
| String sql = "ALTER DB_DISCOVERY TYPE primary_replica_ds_mgr(TYPE(NAME='mgr',PROPERTIES('group-name'='92504d5b'))),primary_replica_ds_mgr_2(TYPE(NAME='mgr'))"; | ||
| AlterDatabaseDiscoveryTypeStatement distSQLStatement = (AlterDatabaseDiscoveryTypeStatement) getDistSQLStatement(sql); | ||
| assertThat(distSQLStatement.getProviders().size(), is(2)); | ||
| assertAlgorithmSegment(distSQLStatement.getProviders().iterator()); | ||
| } | ||
|
|
||
| private void assertDiscoverySegment(final DatabaseDiscoveryDefinitionSegment discoverySegment) { | ||
| assertThat(discoverySegment.getName(), is("db_discovery_group_0")); | ||
| assertThat(discoverySegment.getDataSources(), is(Arrays.asList("ds_0", "ds_1"))); | ||
| Properties properties = new Properties(); | ||
| properties.setProperty("group-name", "92504d5b"); | ||
| assertThat(discoverySegment.getDiscoveryType().getName(), equalTo("mgr")); | ||
| assertThat(discoverySegment.getDiscoveryType().getProps(), equalTo(properties)); | ||
| Properties heartbeatProps = new Properties(); | ||
| heartbeatProps.setProperty("keep-alive-cron", "0/5 * * * * ?"); | ||
| assertThat(discoverySegment.getDiscoveryHeartbeat(), is(heartbeatProps)); | ||
| } | ||
|
|
||
| private void assertAlgorithmSegment(final Iterator<DatabaseDiscoveryProviderAlgorithmSegment> iterator) { | ||
| DatabaseDiscoveryProviderAlgorithmSegment providerAlgorithmSegment = iterator.next(); | ||
| Properties properties = new Properties(); | ||
| properties.setProperty("group-name", "92504d5b"); | ||
| assertThat(providerAlgorithmSegment.getDiscoveryProviderName(), is("primary_replica_ds_mgr")); | ||
| assertThat(providerAlgorithmSegment.getAlgorithm().getName(), is("mgr")); | ||
| assertThat(providerAlgorithmSegment.getAlgorithm().getProps(), is(properties)); | ||
| DatabaseDiscoveryProviderAlgorithmSegment providerAlgorithmSegment2 = iterator.next(); | ||
| assertThat(providerAlgorithmSegment2.getDiscoveryProviderName(), is("primary_replica_ds_mgr_2")); | ||
| assertThat(providerAlgorithmSegment2.getAlgorithm().getName(), is("mgr")); | ||
| assertThat(providerAlgorithmSegment2.getAlgorithm().getProps(), is(new Properties())); | ||
| } | ||
|
|
||
| @SneakyThrows(ReflectiveOperationException.class) | ||
| @SuppressWarnings("rawtypes") | ||
| private DistSQLStatement getDistSQLStatement(final String sql) { | ||
| DatabaseDiscoveryDistSQLStatementParserFacade facade = new DatabaseDiscoveryDistSQLStatementParserFacade(); | ||
| ParseASTNode parseASTNode = (ParseASTNode) SQLParserFactory.newInstance(sql, facade.getLexerClass(), facade.getParserClass()).parse(); | ||
| SQLVisitor visitor = FeaturedDistSQLStatementParserFacadeFactory.getInstance(facade.getType()).getVisitorClass().getDeclaredConstructor().newInstance(); | ||
| return (DistSQLStatement) ((ParseTreeVisitor) visitor).visit(parseASTNode.getRootNode()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.