OneOffJobBootstrap doesn't support parameters

[specYyt]

Hello!

I think OneOffJob is different with SimpleJob or FlowJob.

SimpleJob focus on loop but oneoffjob focus on dispatch. So oneOffJob should have parameters.

Looking forward to your reply!

[Technoboy-]

Yes, we are aware of this issue. We will support it soon.
Please add ( ss_assistant_1) to join our wechat group .

[huran111]

What is the current stable version？

[TeslaCN]

In my opinion, OneOffJob is a type of Bootstrap and SimpleJob or FlowJob are types of ElasticJob, they are different concepts. Parameters can be provided by JobConfiguration and distinguish by ShardingContext. Just create a custom implementation of JobItemExecutor and you can get JobConfiguration and ShardingContext. There is no need to change the API of OneOffJobBootstrap.
What do you think? @Technoboy- @specYyt

[Technoboy-]

In my opinion, OneOffJob is a type of Bootstrap and SimpleJob or FlowJob are types of ElasticJob, they are different concepts. Parameters can be provided by JobConfiguration and distinguish by ShardingContext. Just create a custom implementation of JobItemExecutor and you can get JobConfiguration and ShardingContext. There is no need to change the API of OneOffJobBootstrap.
What do you think? @Technoboy- @specYyt

Yes, keep the current api, and will support parameters in JobConfiguration.

[Technoboy-]

What is the current stable version？

Master branch is more preferred. No unresolved bugs. We are talking about the extension of OneOffJob.

[huran111]

according to OCP ， Yes,keep the current api

…

------------------&nbsp;原始邮件&nbsp;------------------ 发件人: "Tboy"<[email protected]&gt;; 发送时间: 2020年9月2日(星期三) 上午10:19 收件人: "apache/shardingsphere-elasticjob"<[email protected]&gt;; 抄送: "努力努力❌努力"<[email protected]&gt;; "Comment"<[email protected]&gt;; 主题: Re: [apache/shardingsphere-elasticjob] OneOffJobBootstrap doesn&#39;t support parameters (#1430) In my opinion, OneOffJob is a type of Bootstrap and SimpleJob or FlowJob are types of ElasticJob, they are different concepts. Parameters can be provided by JobConfiguration and distinguish by ShardingContext. Just create a custom implementation of JobItemExecutor and you can get JobConfiguration and ShardingContext. There is no need to change the API of OneOffJobBootstrap. What do you think? @Technoboy- @specYyt Yes, keep the current api, and will support parameters in JobConfiguration. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[Technoboy-]

After talking about the details, we think it's not a common scenario, and will not support recently. Thanks for your reporting.