[SEDONA-676] Add ST_Perimeter #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # common/src/main/java/org/apache/sedona/common/sphere/Spheroid.java
github-actions
bot
added
sedona-python
docs
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
labels
jiayuasu
requested changes
Nov 19, 2024
| public static double perimeter(Geometry geometry, boolean use_spheroid, boolean lenient) { | ||
| if (use_spheroid && geometry.getSRID() != 4326) { | ||
| if (lenient) { | ||
| return 0; |
There was a problem hiding this comment.
I would prefer to assume SRID is 4326 if lenient is true. This is particularly useful because most people forget to set SRID for their 4326 geometries.
jiayuasu
approved these changes
Nov 21, 2024
|
@furqaankhan please fix the snowflake failure |
|
@jiayuasu Snowflake test passed |
jiayuasu
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?