Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add pre-commit hook name-tests-test for Python test files #1646

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

jbampton
Copy link
Member

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#name-tests-test

--pytest-test-first: ensure tests match test_.*.py

https://pre-commit.com/#regular-expressions

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No this is a CI update. The PR name follows the format [CI] my subject

What changes were proposed in this PR?

Added another pre-commit hook from the official pre-commit team.

Good to have file naming standards.

How was this patch tested?

Ran pre-commit run --all-files

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

@jiayuasu
Copy link
Member

@jbampton Can you fix this PR?

@jbampton
Copy link
Member Author

Fixed now @jiayuasu

@jiayuasu jiayuasu merged commit 78f035e into apache:master Oct 25, 2024
3 checks passed
@jbampton jbampton deleted the add-pre-commit-hook-name-tests-test branch October 25, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants