Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix doris spark sink return sucess when error occurs #5876

Closed
wants to merge 1 commit into from

Conversation

wwzhe007
Copy link

Purpose of this pull request

Fix doris spark sink always return success when an exception occurs.
For example , doris spark sink return success when you configure the wrong IP or port using doris spark sink , even when sink wrong data.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

example configure file: fenodes="x.x.x.x:80301" with wrong ip or port or wrong data

env {
spark.sql.catalogImplementation=hive
spark.app.name=test_seatunnel_doris_sink
}

source {
hive{
result_table_name=result_table_name
pre_sql="select * from testdb.testtable "
}
}

sink {
doris{
fenodes="x.x.x.x:80301"
database="test"
table="user"
user="doris"
password="doris"
batch_size=10000
doris.column_separator="\t"
doris.columns="c1,c2,..."
}
}

Check list

@hailin0 hailin0 added the First-time contributor First-time contributor label Nov 19, 2023
@Hisoka-X
Copy link
Member

Hi @wwzhe007 , we do not push commit to branch which after we released. If you want to fix some bug, please create a PR for push to dev branch.

@wwzhe007
Copy link
Author

Hi @wwzhe007 , we do not push commit to branch which after we released. If you want to fix some bug, please create a PR for push to dev branch.

ok, I got it.

@Hisoka-X Hisoka-X closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time contributor First-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants