Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2][Github] Adding Github Source Connector #4155

Merged
merged 12 commits into from
Feb 20, 2023
Merged

[Feature][Connector-V2][Github] Adding Github Source Connector #4155

merged 12 commits into from
Feb 20, 2023

Conversation

Al-assad
Copy link
Member

@Al-assad Al-assad commented Feb 17, 2023 •
edited
Loading

Purpose of this pull request

Adding Github API data source connector based on http-connector.
Related issue: #3018

Check list

@Al-assad Al-assad closed this Feb 17, 2023
@Al-assad Al-assad reopened this Feb 17, 2023
@Al-assad
Copy link
Member Author

@CalvinKirs @TyrantLucifer @EricJoy2048 @ashulin PTAL.

@Al-assad
Copy link
Member Author

@liugddx @TyrantLucifer Thanks for your suggestions, please take a look agian.

@Al-assad Al-assad requested review from liugddx and TyrantLucifer and removed request for liugddx and TyrantLucifer February 20, 2023 13:30
TyrantLucifer
TyrantLucifer reviewed Feb 20, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml

@TyrantLucifer
Copy link
Member

Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml

Sorry my fault, you also should update release-note https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md too

@TyrantLucifer
Copy link
Member

Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml

Sorry my fault, you also should update release-note https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md too

image

@Al-assad
Copy link
Member Author

Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml

Resolved 😃.

@liugddx
Copy link
Member

liugddx commented Feb 20, 2023

Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml

Resolved 😃.

You should update release-note.md for this pr.

TyrantLucifer
TyrantLucifer previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, let's waiting CI. cc @liugddx

liugddx
liugddx previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Al-assad Al-assad dismissed stale reviews from liugddx and TyrantLucifer via e700866 February 20, 2023 14:32
@Al-assad
Copy link
Member Author

I just submitted an update to the release-note and the approval status will be dimissed again in the github mechanism, please re-add your approval, thanks.

@TyrantLucifer TyrantLucifer merged commit 49d9172 into apache:dev Feb 20, 2023
@EricJoy2048 EricJoy2048 mentioned this pull request Mar 6, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liugddx liugddx liugddx approved these changes

@TyrantLucifer TyrantLucifer TyrantLucifer approved these changes

Assignees
No one assigned
Labels
approved reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-assad @TyrantLucifer @liugddx