[Feature][Connector-V2][Teradata] Add Teradata Source And Sink Connector #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FWLamb
changed the title
|
|
|
|
|
Do we need to use jdbc dialect? @hailin0 |
FWLamb
force-pushed
the
connector-teradata
branch
from
a2b2b21
to
4b57737
Compare
|
|
FWLamb
force-pushed
the
connector-teradata
branch
from
a28209b
to
e2d90be
Compare
hailin0
reviewed
Nov 15, 2022
...he/seatunnel/connectors/seatunnel/jdbc/internal/connection/SimpleJdbcConnectionProvider.java
Outdated
Show resolved
Hide resolved
FWLamb
force-pushed
the
connector-teradata
branch
from
1a50663
to
e88d463
Compare
|
|
|
@ic4y @hailin0 @EricJoy2048 @TaoZex PTAL. |
ic4y
reviewed
Nov 17, 2022
...ector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/utils/JdbcUtils.java
Outdated
Show resolved
Hide resolved
FWLamb
force-pushed
the
connector-teradata
branch
from
3cbdf68
to
ded5481
Compare
FWLamb
force-pushed
the
connector-teradata
branch
from
9d43606
to
1b406b5
Compare
hailin0
reviewed
Nov 21, 2022
Comment on lines
+52
to
+56
| public void testTeradata(TestContainer container) throws Exception { | ||
| container.executeExtraCommands(extendedFactory); | ||
| Container.ExecResult execResult = container.executeJob("/jdbc_teradata_source_and_sink.conf"); | ||
| Assertions.assertEquals(0, execResult.getExitCode()); | ||
| clearSinkTable(); |
There was a problem hiding this comment.
@FWLamb
Please reference to JdbcOracledbIT validation data input and output
There was a problem hiding this comment.
Teradata does not have a Docker image, and it seems that it cannot be made by itself.
EricJoy2048
approved these changes
Nov 28, 2022
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Refer to #3018
Add Teradata Source And Sink Connector.
Check list
Check list
New License Guide