[Feature][Connector-V2] Socket Connector Sink #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyrantLucifer
requested changes
Aug 28, 2022
...socket/src/main/java/org/apache/seatunnel/connectors/seatunnel/socket/config/SinkConfig.java
Outdated
Show resolved
Hide resolved
...r-socket/src/main/java/org/apache/seatunnel/connectors/seatunnel/socket/sink/SocketSink.java
Show resolved
Hide resolved
...et/src/main/java/org/apache/seatunnel/connectors/seatunnel/socket/sink/SocketSinkWriter.java
Outdated
Show resolved
Hide resolved
|
BTW, please fix CI first. |
TyrantLucifer
requested changes
Aug 28, 2022
| private String host; | ||
| private Integer port; | ||
| private int port; | ||
| private Integer maxNumRetries = DEFAULT_MAX_RETRIES; |
There was a problem hiding this comment.
Thank you very much for your advice. I have fixed the problems mentioned above
|
LGTM, let's waiting CI, cc @CalvinKirs |
|
The CodeQL/Analyze (Java) step in CI was cancelled,. I think the overall compilation of the project timed out. |
Could you please help him restart the CI process? @Hisoka-X |
CalvinKirs
approved these changes
Aug 28, 2022
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Aug 30, 2022
* [Feature][Connector-V2] Add Socket Connector Sink * add License * fix code style * fix code style Co-authored-by: 毕博 <[email protected]>
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 8, 2022
* [Feature][Connector-V2] Add Socket Connector Sink * add License * fix code style * fix code style Co-authored-by: 毕博 <[email protected]>
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 15, 2022
* [Feature][Connector-V2] Add Socket Connector Sink * add License * fix code style * fix code style Co-authored-by: 毕博 <[email protected]>
MRYOG
pushed a commit
to MRYOG/incubator-seatunnel
that referenced
this pull request
Sep 16, 2022
* [Feature][Connector-V2] Add Socket Connector Sink * add License * fix code style * fix code style Co-authored-by: 毕博 <[email protected]>
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
* [Feature][Connector-V2] Add Socket Connector Sink * add License * fix code style * fix code style Co-authored-by: 毕博 <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1946
Add Socket Connector Sink
the output format is json format
Purpose of this pull request
Check list
New License Guide