[Feature][Connector-V2] new connecotor of Elasticsearch sink(#2326) #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalvinKirs
reviewed
Aug 2, 2022
CalvinKirs
reviewed
Aug 2, 2022
| request.setJsonEntity(requestBody); | ||
| try { | ||
| Response response = restClient.performRequest(request); | ||
| if (response.getStatusLine().getStatusCode() == 200) { |
There was a problem hiding this comment.
It's better use HttpStatus judge.
There was a problem hiding this comment.
I have revised it according to your suggestion.
|
could you submit this PR to dev branch(not api-draft) |
|
@Hisoka-X hi,PTAL,thx |
Hisoka-X
previously approved these changes
Aug 4, 2022
|
Hi please resolve dependency check error |
…ent version to 7.5.1 that existed before (apache#2326)
CalvinKirs
approved these changes
Aug 5, 2022
TyrantLucifer
pushed a commit
to TyrantLucifer/incubator-seatunnel
that referenced
this pull request
Sep 18, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request add new connecotor of Elasticsearch sink.(#2326)
Check list
New License Guide