Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Seatunnel-web] Seatunnel-web always requires the cluster name to be seatunnel #174

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

arshadmohammad
Copy link
Collaborator

Purpose of this pull request

Problem:
Seatunnel-web always requires the cluster name to be "seatunnel"
I configured "cluster-name: seatunnel-test" in hazelcast.yaml and also added "cluster-name: seatunnel-test" in hazelcast-client.yaml in seatunnel-web config, job execution was failing.

Proposal:
Remove the hard coding of cluster name. Read the cluster name from hazelcast-client.yam

Check list

Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davidzollo davidzollo merged commit 6d99a72 into apache:main Aug 8, 2024
15 checks passed
@arshadmohammad
Copy link
Collaborator Author

Thanks @davidzollo for reviewing and merging the PR.

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 8, 2024

Thanks @arshadmohammad !

@arshadmohammad arshadmohammad self-assigned this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants