Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8966] Feat: add remote address information to acl perm error #8967

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Nov 21, 2024

closes #8966
image

@humkum humkum changed the title [ISSUE #8966]feat: add remote address information to acl perm error [ISSUE #8966] Feat: add remote address information to acl perm error Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.65%. Comparing base (9202de3) to head (b19b950).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...rocketmq/remoting/netty/NettyRemotingAbstract.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8967      +/-   ##
=============================================
- Coverage      47.73%   47.65%   -0.09%     
+ Complexity     11774    11756      -18     
=============================================
  Files           1304     1304              
  Lines          91118    91150      +32     
  Branches       11692    11700       +8     
=============================================
- Hits           43495    43436      -59     
- Misses         42264    42335      +71     
- Partials        5359     5379      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add remote addr information for acl error log.
4 participants