Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8957] Remove excess traffic and fix cache inconsistencies #8958

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

3424672656
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8957
Fixes #8686

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (c13f051) to head (6c4cf37).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8958      +/-   ##
=============================================
+ Coverage      47.66%   47.67%   +0.01%     
+ Complexity     11760    11748      -12     
=============================================
  Files           1303     1303              
  Lines          91064    91034      -30     
  Branches       11681    11672       -9     
=============================================
- Hits           43408    43405       -3     
+ Misses         42282    42263      -19     
+ Partials        5374     5366       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@humkum
Copy link
Contributor

humkum commented Nov 20, 2024

Why is this deleted? IMO, only the first startup will make a request to the server,will not bring more network traffic.

@3424672656
Copy link
Contributor Author

Why is this deleted? IMO, only the first startup will make a request to the server,will not bring more network traffic.

Normally, if rebalance=false is enabled, all topics will be rebalanced on the server as they are added to the topicBrokerRebalance collection, but when a network issue occurs, Some topics will be added topicClientRebalance, and this part of the client will be rebalanced in PULL.

Since it should be carried out on the server side, there is no need for this network communication, which not only brings overhead but also causes cache errors. It is better to remove this part

@3424672656
Copy link
Contributor Author

3424672656 commented Nov 20, 2024

@hill007299 @lizhimins Excuse me,Is the design here for version compatibility or is there some other consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants