Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8835]When ck is in the buffer, incomplete ack will lead to message duplication. #8836

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

GenerousMan
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8835

Brief Description

How Did You Test This Change?

@GenerousMan
Copy link
Contributor Author

The reason for this issue is that the Ack was put to store from the buffer without writing the brokerName. This variable is essential during the merge process.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.39%. Comparing base (5496807) to head (f7ea7ef).
Report is 49 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8836      +/-   ##
=============================================
- Coverage      47.42%   47.39%   -0.04%     
- Complexity     11514    11599      +85     
=============================================
  Files           1277     1283       +6     
  Lines          89438    90010     +572     
  Branches       11502    11584      +82     
=============================================
+ Hits           42416    42657     +241     
- Misses         41812    42111     +299     
- Partials        5210     5242      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 031687d into apache:develop Oct 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] When CK is in the buffer, incomplete ACK will lead to message duplication.
4 participants