Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6795] feat: support to send transaction msg with lmqQueue property #6796

Closed
wants to merge 1 commit into from

Conversation

cserwen
Copy link
Member

@cserwen cserwen commented May 23, 2023

Which Issue(s) This PR Fixes

Fixes #6795

Brief Description

How Did You Test This Change?

@cserwen cserwen requested a review from RongtongJin May 23, 2023 04:07
@codecov-commenter
Copy link

Codecov Report

Merging #6796 (bdbbbe8) into develop (f33ac2a) will increase coverage by 0.00%.
The diff coverage is 14.28%.

@@             Coverage Diff             @@
##             develop    #6796    +/-   ##
===========================================
  Coverage      42.89%   42.90%            
+ Complexity      9007     8990    -17     
===========================================
  Files           1113     1104     -9     
  Lines          78591    78384   -207     
  Branches       10221    10210    -11     
===========================================
- Hits           33709    33627    -82     
+ Misses         40659    40536   -123     
+ Partials        4223     4221     -2     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 43.46% <0.00%> (-0.08%) ⬇️
...apache/rocketmq/broker/slave/SlaveSynchronize.java 4.16% <0.00%> (-0.03%) ⬇️
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 66.19% <50.00%> (-0.32%) ⬇️

... and 59 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@HScarb HScarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also add a check in checkMultiDispatchQueue method?

@cserwen
Copy link
Member Author

cserwen commented May 26, 2023

checkMultiDispatchQueue

I don't think this is necessary. We have checked the message and assigned the queueOffset when writing it. If the index is not built because the check fails in the checkMultiDispatchQueue, the index offset will be discontinuous. However, in checkMultiDispatchQueue format validation is necessary.

@cserwen
Copy link
Member Author

cserwen commented Jul 11, 2023

@HScarb Plz help me to review this.

Copy link

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

@github-actions github-actions bot added the stale label Jul 11, 2024
Copy link

This PR was closed because it has been inactive for 3 days since being marked as stale.

@github-actions github-actions bot closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support to send transaction msg with lmqQueue property
3 participants