Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#662]capitalizing the first letter in comments and removing the unless comments for acl and msg trace feature codes. #669

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

zongtanghu
Copy link
Contributor

What is the purpose of the change

I have already capitalized the first letter in comments and removed the unless comments for acl and msg trace feature codes.

Brief changelog

The changed files is as follows.

Verifying this change

I have already verified.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

… unless comments for acl and msg trace feature codes.
@coveralls
Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage increased (+0.07%) to 44.862% when pulling 28bb467 on zongtanghu:msg_track into ea8d517 on apache:msg_track.

@dongeforever dongeforever merged commit 691b712 into apache:msg_track Jan 7, 2019
xiangwangcheng pushed a commit to xiangwangcheng/rocketmq that referenced this pull request Jan 14, 2019
… unless comments for acl and msg trace feature codes. (apache#669)

* [ISSUE#662]capitalizing the first letter in comments and removing the  unless comments for acl and msg trace feature codes.

* [ISSUE#662]polish the acl feature codes.
@ShannonDing ShannonDing added this to the 4.4.0 milestone Jan 16, 2019
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
… unless comments for acl and msg trace feature codes. (apache#669)

* [ISSUE#662]capitalizing the first letter in comments and removing the  unless comments for acl and msg trace feature codes.

* [ISSUE#662]polish the acl feature codes.
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
… unless comments for acl and msg trace feature codes. (apache#669)

* [ISSUE#662]capitalizing the first letter in comments and removing the  unless comments for acl and msg trace feature codes.

* [ISSUE#662]polish the acl feature codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants