Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#403]Implement the acl strandard for rocketmq #519

Merged
merged 6 commits into from
Nov 9, 2018
Merged

[ISSUE#403]Implement the acl strandard for rocketmq #519

merged 6 commits into from
Nov 9, 2018

Conversation

githublaohu
Copy link
Contributor

@githublaohu githublaohu commented Nov 2, 2018

What is the purpose of the change

Implement the acl strandard for rocketmq(实现RocketMQ 的ACL标准)

Brief changelog

  1. Implement strandard is as follows(接口标准如下)
    AccessResource Used to get the data in the request(用于获得请求中数据)
    AccessValidator Used to perform authentication(用于进行鉴权)

  2. The implement is SPI(实现方式为SPI)
    neet to create ”org.apache.rocketmq.acl.AccessValidator“ file in the META-INF/service/ directory。Write in file Class fully qualified name

需要在 META-INF/service/目录下创建 ”org.apache.rocketmq.acl.AccessValidator“ 文件,在文件里面写入实现类的完全限定名

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [√] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [√] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage increased (+0.3%) to 42.997% when pulling 11d3df6 on githublaohu:feature_acl into aeea021 on apache:feature_acl.

@githublaohu githublaohu changed the title 实现RocketMQ的acl标准 Implement the acl strandard for rocketmq Nov 2, 2018
@vongosling vongosling changed the title Implement the acl strandard for rocketmq [ISSUE#403] Implement the acl strandard for rocketmq Nov 6, 2018
@vongosling vongosling changed the title [ISSUE#403] Implement the acl strandard for rocketmq [ISSUE#403]Implement the acl strandard for rocketmq Nov 6, 2018
@dongeforever dongeforever merged commit 2d4cda2 into apache:feature_acl Nov 9, 2018
@ShannonDing ShannonDing added this to the 4.4.0 milestone Jan 16, 2019
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
[ISSUE#403]Implement the acl strandard for rocketmq
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
[ISSUE#403]Implement the acl strandard for rocketmq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants