[ISSUE #4273] Fix DLedgerRpcNettyService can not communicate with each other when tls enabled

[zhanxuefeng]

Make sure set the target branch to develop

What is the purpose of the change

Fix DLedgerRpcNettyService can not communicate with each other when tls enabled
ISSUE #4273

Brief changelog

NettyRemotingClient load the tls conf from system properties

[hzh0425]

Oh, what a careful discovery.
For optino 'useTLS' of NettyClientConfig, the configuration in BrokerStartup # createBrokerController is as follows:

But Dledger # DledgerRpcNettyService directly ignores this option, it should be missed, in addition to this pr, maybe you should initiate a pr in the dledger community to supplement.

[codecov-commenter]

Codecov Report

Merging #4274 (4a0f258) into develop (446b76b) will increase coverage by 0.57%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4274      +/-   ##
=============================================
+ Coverage      47.61%   48.18%   +0.57%     
- Complexity      4958     5111     +153     
=============================================
  Files            633      646      +13     
  Lines          42577    42911     +334     
  Branches        5589     5611      +22     
=============================================
+ Hits           20273    20678     +405     
+ Misses         19796    19724      -72     
- Partials        2508     2509       +1     

Impacted Files	Coverage Δ
...e/rocketmq/remoting/netty/NettyRemotingClient.java	46.04% <0.00%> (-0.57%)	⬇️
...apache/rocketmq/broker/client/ProducerManager.java	71.81% <0.00%> (-13.74%)	⬇️
...broker/processor/AbstractSendMessageProcessor.java	40.62% <0.00%> (-8.68%)	⬇️
...he/rocketmq/remoting/protocol/RemotingCommand.java	70.32% <0.00%> (-8.30%)	⬇️
...in/java/org/apache/rocketmq/test/util/MQAdmin.java	38.88% <0.00%> (-5.56%)	⬇️
...g/apache/rocketmq/remoting/netty/NettyEncoder.java	46.15% <0.00%> (-3.85%)	⬇️
...n/java/org/apache/rocketmq/store/RunningFlags.java	31.11% <0.00%> (-2.23%)	⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java	74.50% <0.00%> (-1.67%)	⬇️
...lient/impl/consumer/DefaultMQPushConsumerImpl.java	40.84% <0.00%> (-1.62%)	⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java	72.05% <0.00%> (-1.48%)	⬇️
... and 111 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446b76b...4a0f258. Read the comment docs.

[hzh0425]

Can you re-trigger ci test? @zhanxuefeng

[coveralls]

Coverage decreased (-0.1%) to 52.096% when pulling 4a0f258 on zhanxuefeng:dledger into 73b9ac8 on apache:develop.

[coveralls]

Coverage decreased (-0.1%) to 52.096% when pulling 4a0f258 on zhanxuefeng:dledger into 73b9ac8 on apache:develop.

[zhanxuefeng]

Can you re-trigger ci test? @zhanxuefeng

done

[github-actions]

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

[github-actions]

This PR was closed because it has been inactive for 3 days since being marked as stale.