-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in getStartIndex method in RocketMQ_Example.md file #4012
Conversation
Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever
方法getStartIndex() 中messages.get(curIndex)修正为messages.get(currIndex);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link this pr to related issue.
Codecov Report
@@ Coverage Diff @@
## develop #4012 +/- ##
=============================================
+ Coverage 47.53% 47.65% +0.12%
- Complexity 4931 4952 +21
=============================================
Files 633 633
Lines 42497 42497
Branches 5579 5579
=============================================
+ Hits 20201 20252 +51
+ Misses 19798 19753 -45
+ Partials 2498 2492 -6
Continue to review full report at Codecov.
|
…pache#4012) * Update .travis.yml Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever * Updated Notice file to 2022 (apache#3735) * 4.2消息列表分割示例 getStartIndex方法中变量名称错误 方法getStartIndex() 中messages.get(curIndex)修正为messages.get(currIndex); Co-authored-by: von gosling <[email protected]> Co-authored-by: ZhangJian He <[email protected]> Co-authored-by: tigerweili <[email protected]>
Make sure set the target branch to
develop
What is the purpose of the change
Fix RocketMQ_Example.md
Brief changelog
4.2消息列表分割示例 getStartIndex方法中变量名称错误
Verifying this change
messages.get(curIndex) -> messages.get(currIndex)
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.