Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in getStartIndex method in RocketMQ_Example.md file #4012

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

zfs9521
Copy link
Contributor

@zfs9521 zfs9521 commented Mar 20, 2022

Make sure set the target branch to develop

What is the purpose of the change

Fix RocketMQ_Example.md

Brief changelog

4.2消息列表分割示例 getStartIndex方法中变量名称错误

Verifying this change

messages.get(curIndex) -> messages.get(currIndex)

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

vongosling and others added 4 commits December 10, 2021 17:30
Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever
方法getStartIndex() 中messages.get(curIndex)修正为messages.get(currIndex);
Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link this pr to related issue.

@zfs9521 zfs9521 changed the title Patch 1 Fixed typo in getStartIndex method in RocketMQ_Example.md file Mar 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4012 (2622ba3) into develop (b606d9c) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 2622ba3 differs from pull request most recent head 525e21f. Consider uploading reports for the commit 525e21f to get more accurate results

@@              Coverage Diff              @@
##             develop    #4012      +/-   ##
=============================================
+ Coverage      47.53%   47.65%   +0.12%     
- Complexity      4931     4952      +21     
=============================================
  Files            633      633              
  Lines          42497    42497              
  Branches        5579     5579              
=============================================
+ Hits           20201    20252      +51     
+ Misses         19798    19753      -45     
+ Partials        2498     2492       -6     
Impacted Files Coverage Δ
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
.../apache/rocketmq/logging/inner/LoggingBuilder.java 64.87% <0.00%> (+0.15%) ⬆️
...a/org/apache/rocketmq/store/StoreStatsService.java 30.61% <0.00%> (+0.65%) ⬆️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 81.18% <0.00%> (+1.48%) ⬆️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 48.58% <0.00%> (+1.97%) ⬆️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 62.39% <0.00%> (+2.56%) ⬆️
...pache/rocketmq/remoting/common/RemotingHelper.java 23.07% <0.00%> (+3.29%) ⬆️
...va/org/apache/rocketmq/common/stats/StatsItem.java 55.00% <0.00%> (+5.00%) ⬆️
.../apache/rocketmq/common/stats/MomentStatsItem.java 47.61% <0.00%> (+9.52%) ⬆️
...org/apache/rocketmq/common/stats/StatsItemSet.java 53.73% <0.00%> (+10.44%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b606d9c...525e21f. Read the comment docs.

@yuz10 yuz10 merged commit 9f82b1e into apache:develop Apr 6, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…pache#4012)

* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* 4.2消息列表分割示例  getStartIndex方法中变量名称错误

方法getStartIndex() 中messages.get(curIndex)修正为messages.get(currIndex);

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
Co-authored-by: tigerweili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants