Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update best_practice.md #3939

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Update best_practice.md #3939

merged 4 commits into from
Mar 8, 2022

Conversation

HMYDK
Copy link
Contributor

@HMYDK HMYDK commented Mar 7, 2022

fix word

Make sure set the target branch to develop

What is the purpose of the change

fix doc word

@duhenglucky duhenglucky changed the base branch from master to develop March 7, 2022 10:59
@duhenglucky duhenglucky changed the base branch from develop to master March 7, 2022 10:59
@francisoliverlee francisoliverlee added this to the 4.9.4 milestone Mar 7, 2022
@panzhi33
Copy link
Contributor

panzhi33 commented Mar 8, 2022

Please modify the branch to develop

@yuz10 yuz10 changed the base branch from master to develop March 8, 2022 08:29
@yuz10 yuz10 merged commit 446b76b into apache:develop Mar 8, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* Update best_practice.md

fix word

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
Co-authored-by: tigerweili <[email protected]>
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
* Update .travis.yml

Depracated MODERATE noisy mail for [email protected]. Still Failing: apache#5670 (5.0.0-alpha-static-topic - 5ebc327) @dongeforever

* Updated Notice file to 2022 (apache#3735)

* Update best_practice.md

fix word

Co-authored-by: von gosling <[email protected]>
Co-authored-by: ZhangJian He <[email protected]>
Co-authored-by: tigerweili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants