Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #353]Optimzation For Unit Test #356

Merged
merged 6 commits into from
Jul 5, 2018

Conversation

Hellojungle
Copy link
Contributor

@Hellojungle Hellojungle commented Jul 4, 2018

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

To decrease the time of conducting unit test.

Brief changelog

Decreased thread-sleep time and used StringBuffer and so on.

.travis.yml Outdated
@@ -3,7 +3,7 @@ notifications:
recipients:
- [email protected]
on_success: change
on_failure: always
on_failure: never
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -314,8 +318,11 @@
<artifactId>maven-surefire-plugin</artifactId>
<version>2.19.1</version>
<configuration>
<skipAfterFailureCount>1</skipAfterFailureCount>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good polish

pom.xml Outdated
@@ -423,6 +433,7 @@
<argLine>@{failsafeArgLine}</argLine>
<excludes>
<exclude>**/NormalMsgDelayIT.java</exclude>
<exclude>**/*Test.java</exclude>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@coveralls
Copy link

coveralls commented Jul 4, 2018

Coverage Status

Coverage increased (+0.05%) to 41.4% when pulling d4885c7 on what-a-good-jungle:optimzationforunittest into 650f46b on apache:develop.

@vongosling
Copy link
Member

Thanks @what-a-good-jungle . LGTM, I will merge the pr when the checks all pass

@vongosling vongosling merged commit 94f3b5a into apache:develop Jul 5, 2018
renshuaibing-aaron pushed a commit to renshuaibing-aaron/rocketmq that referenced this pull request Apr 13, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants