-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #1308] Fix some spelling errors of method names. #1307
Conversation
@zongtanghu hi !Could u help me with this PR in your busy schedule ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kinoko1996 |
I'd love to do that. But this PR is merged, and I need to propose an additional Pr to fix it. |
What is the purpose of the change
#1308
Fix some spelling errors of method names in file named 'UtilAll.java'
These changes seem trivial, but it's an international project and I think the right naming helps other developers understand it.
Brief changelog
the UtilAll.computeEclipseTimeMilliseconds was modified to UtilAll.computeElapsedTimeMilliseconds
(I think this method is to calculate the elapsed time by giving the start time.)
'computNextMorningTimeMillis' was modified to 'computeNextMorningTimeMillis '
'computNextHourTimeMillis' was modified to 'computeNextHourTimeMillis '
'computNextMinutesTimeMillis' was modified to 'computeNextMinutesTimeMillis '
'computNextHalfHourTimeMillis' was modified to 'computeNextHalfHourTimeMillis '
Verifying this change
Nothing.
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.