Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1082] Fix disconnection of HA #1083

Merged
merged 3 commits into from
Jul 27, 2019
Merged

[ISSUE #1082] Fix disconnection of HA #1083

merged 3 commits into from
Jul 27, 2019

Conversation

zhanguohuang
Copy link
Contributor

@zhanguohuang zhanguohuang commented Mar 13, 2019

What is the purpose of the change

When no message is sent, the master and slave connections are not frequently disconnected.
The logic of reporting heartbeat on slave has been adjusted to make it work better.

Brief changelog

Adjusted lastWriteTimestamp of HAClient.

Verifying this change

Start a master and slave in the default way. Whether or not a message is sent, the master will not disconnect from the slave unless there is an exception.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@zhanguohuang zhanguohuang changed the title [ISSUE 1082] Fix the bug of disconnection of HA [ISSUE 1082] Fix disconnection of HA Mar 13, 2019
@coveralls
Copy link

coveralls commented Mar 13, 2019

Coverage Status

Coverage increased (+0.07%) to 49.414% when pulling 8fe5c69 on zhanguohuang:develop into 7b1ef8f on apache:develop.

@zhanguohuang zhanguohuang changed the title [ISSUE 1082] Fix disconnection of HA [ISSUE #1082] Fix disconnection of HA Mar 22, 2019
@RongtongJin
Copy link
Contributor

LGTM

@duhenglucky duhenglucky added this to the 4.6.0 milestone Jul 24, 2019
@vongosling vongosling merged commit b39031a into apache:develop Jul 27, 2019
supercym pushed a commit to supercym/rocketmq that referenced this pull request Aug 22, 2019
duhenglucky pushed a commit that referenced this pull request Aug 22, 2019
* Remove the useless files

* Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122

* Update DLedgerCommitLog.java (#1145)

Delete useless code

* Remove the duplicate content

* Polish the comment (#1107)

* Minor Typo fix  (#860)

* [ISSUE #1082] Fix disconnection of HA (#1083)

* fixed the text description in chinese doc (#1339)

* fix /dev/shm not found on some OSs (#1345)

* Refactor the protection logic when pulling

* change the MQVersion variable to rocketmq 4.5.2 version;

* Minor polish

* Fix the wrong package name

* [maven-release-plugin] prepare release rocketmq-all-4.5.2

* [maven-release-plugin] prepare for next development iteration

* [RIP-15]Add Ipv6 support for RocketMQ
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
* Remove the useless files

* Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122

* Update DLedgerCommitLog.java (apache#1145)

Delete useless code

* Remove the duplicate content

* Polish the comment (apache#1107)

* Minor Typo fix  (apache#860)

* [ISSUE apache#1082] Fix disconnection of HA (apache#1083)

* fixed the text description in chinese doc (apache#1339)

* fix /dev/shm not found on some OSs (apache#1345)

* Refactor the protection logic when pulling

* change the MQVersion variable to rocketmq 4.5.2 version;

* Minor polish

* Fix the wrong package name

* [maven-release-plugin] prepare release rocketmq-all-4.5.2

* [maven-release-plugin] prepare for next development iteration

* [RIP-15]Add Ipv6 support for RocketMQ
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
* Remove the useless files

* Replace PermSize with MetaspaceSize, details see http://openjdk.java.net/jeps/122

* Update DLedgerCommitLog.java (apache#1145)

Delete useless code

* Remove the duplicate content

* Polish the comment (apache#1107)

* Minor Typo fix  (apache#860)

* [ISSUE apache#1082] Fix disconnection of HA (apache#1083)

* fixed the text description in chinese doc (apache#1339)

* fix /dev/shm not found on some OSs (apache#1345)

* Refactor the protection logic when pulling

* change the MQVersion variable to rocketmq 4.5.2 version;

* Minor polish

* Fix the wrong package name

* [maven-release-plugin] prepare release rocketmq-all-4.5.2

* [maven-release-plugin] prepare for next development iteration

* [RIP-15]Add Ipv6 support for RocketMQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants