You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue tracker is ONLY used for bug report and feature request. Keep in mind, please check whether there is an existing same report before your raise a new one.
Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration and other improvements.
Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:
BUG REPORT
Please describe the issue you observed:
What did you do (The steps to reproduce)?
What did you expect to see?
What did you see instead?
Please tell us about your environment:
Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
FEATURE REQUEST
Please describe the feature you are requesting.
Upon on the logic of check transactional message(TransactionalMessageServiceImpl#check), when checked times exceeds the transactionCheckMax(15 by default), the DefaultTransactionalMessageCheckListener#resolveDiscardMsg is invoked, which just logs an error message.
I think some more meaningful logic should be done such as put it into another system topic for manual intervention later.
Provide any additional detail on your proposed use case for this feature.
Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
should-have, I guess.
If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
…check times to system topic (#633)
* add logic of putting message that exceeds max-check-times to system topic TRANS_CHECK_MAXTIME_TOPIC
* add test case:testResolveDiscardMsg
* add @after logic to test case
* comment brokerController.shutdown and use mock
* add logic of resuming half message check
* add test case:resumeCheckHalfMessage
* delete commented codes
…d max check times to system topic (apache#633)
* add logic of putting message that exceeds max-check-times to system topic TRANS_CHECK_MAXTIME_TOPIC
* add test case:testResolveDiscardMsg
* add @after logic to test case
* comment brokerController.shutdown and use mock
* add logic of resuming half message check
* add test case:resumeCheckHalfMessage
* delete commented codes
pulllock
pushed a commit
to pulllock/rocketmq
that referenced
this issue
Oct 19, 2023
…d max check times to system topic (apache#633)
* add logic of putting message that exceeds max-check-times to system topic TRANS_CHECK_MAXTIME_TOPIC
* add test case:testResolveDiscardMsg
* add @after logic to test case
* comment brokerController.shutdown and use mock
* add logic of resuming half message check
* add test case:resumeCheckHalfMessage
* delete commented codes
The issue tracker is ONLY used for bug report and feature request. Keep in mind, please check whether there is an existing same report before your raise a new one.
Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration and other improvements.
Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:
BUG REPORT
What did you do (The steps to reproduce)?
What did you expect to see?
What did you see instead?
Please tell us about your environment:
Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
FEATURE REQUEST
Please describe the feature you are requesting.
Upon on the logic of check transactional message(TransactionalMessageServiceImpl#check), when checked times exceeds the transactionCheckMax(15 by default), the DefaultTransactionalMessageCheckListener#resolveDiscardMsg is invoked, which just logs an error message.
I think some more meaningful logic should be done such as put it into another system topic for manual intervention later.
Provide any additional detail on your proposed use case for this feature.
Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
should-have, I guess.
If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
The text was updated successfully, but these errors were encountered: