Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] remove is_started condition check because telemetry_command_tx… #711

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

glcrazier
Copy link
Contributor

… is suffice to tell

Which Issue(s) This PR Fixes

Fixes #707

Brief Description

There is no need to check is_started because telemetry_command_tx is suffice to tell if client is ready.

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.60%. Comparing base (430ed16) to head (0fbb1b3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #711      +/-   ##
============================================
- Coverage     56.05%   47.60%   -8.45%     
  Complexity      664      664              
============================================
  Files           259      207      -52     
  Lines         15856    12353    -3503     
  Branches       4089     3705     -384     
============================================
- Hits           8888     5881    -3007     
+ Misses         6679     6183     -496     
  Partials        289      289              
Flag Coverage Δ
nodejs ?
rust 79.70% <ø> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lizhanhui lizhanhui merged commit efe006e into apache:master Mar 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Rust: Client is not running at session.update_settings
3 participants