Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #953] fix limiter with goroutine cover #952

Merged

Conversation

maqingxiang
Copy link
Contributor

@maqingxiang maqingxiang commented Oct 28, 2022

What is the purpose of the change

add gotorutine restriction for limiter, avoid creating goroutine excessively.

Brief changelog

push_consumer.go

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@maqingxiang
Copy link
Contributor Author

@ShannonDing @superhx @NeonToo 帮忙看下,是否可以修改为在并发控制的范围内进行自定义流控,避免无限制创建 goroutine 的风险

@maqingxiang maqingxiang changed the title fix limiter with goroutine cover [953] fix limiter with goroutine cover Nov 1, 2022
@maqingxiang maqingxiang changed the title [953] fix limiter with goroutine cover [ISSUE #953]fix limiter with goroutine cover Nov 1, 2022
@maqingxiang maqingxiang changed the title [ISSUE #953]fix limiter with goroutine cover [ISSUE #953] fix limiter with goroutine cover Nov 1, 2022
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShannonDing ShannonDing merged commit 96f00c4 into apache:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants