Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #933] fix retry topic and namespace topic block #934

Closed
wants to merge 2 commits into from

Conversation

0daypwn
Copy link
Contributor

@0daypwn 0daypwn commented Oct 10, 2022

What is the purpose of the change

close #933

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the bug Something isn't working label Oct 11, 2022
@0daypwn
Copy link
Contributor Author

0daypwn commented Oct 11, 2022

map is not thread safe, so should add RWMutex.
The design is too complicated. Maybe there's a better way?

@ShannonDing
Copy link
Member

@0daypwn , hi, it seems have conflicts after PR #944 merged, could you pls fix it and and have a test after the crCh initialized?

@0daypwn
Copy link
Contributor Author

0daypwn commented Oct 14, 2022

The purpose of these two is the same.

but the pc.crCh Map may be read and written concurrently in two places

  • Subscribe
  • consumeMessageCurrently
    it may cause panic.

@ShannonDing @NeonToo

@maixiaohai
Copy link
Contributor

截屏2022-10-24 20 42 32

@0daypwn pls resolve the conflicts first

@0daypwn 0daypwn closed this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topic with namespace and retry is block
3 participants