Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix rebalance is not paused after suspend and rebalance not trigge… #852

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

NeonToo
Copy link
Contributor

@NeonToo NeonToo commented Jul 5, 2022

What is the purpose of the change

[BUGFIX] reset offset not work correctly

  • rebalance is not paused after suspend
  • pc.removeUnnecessaryMessageQueue & processQueueTable.Delete not work as expected since the judege on exist always return false

Brief changelog

  • pause rebalance after suspend
  • use copyPc to operate pc.removeUnnecessaryMessageQueue & processQueueTable.Delete

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@maqingxiang
Copy link
Contributor

LGTM.

@ShannonDing ShannonDing added the bug Something isn't working label Jul 12, 2022
@ShannonDing ShannonDing added this to the 2.2.0 milestone Jul 12, 2022
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duhenglucky duhenglucky merged commit ade7cfa into apache:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants