-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #698] fix: call cancel() as soon as possible to release the resources associatd with context #691
Conversation
…iatd with context
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
+ Coverage 24.71% 24.74% +0.02%
==========================================
Files 48 48
Lines 5223 5234 +11
==========================================
+ Hits 1291 1295 +4
- Misses 3726 3733 +7
Partials 206 206
Continue to review full report at Codecov.
|
It seems that the changes of this PR included in #692 could you separate them or close this PR? |
ok. I will separate them in #692. Could you accept this PR first? |
this PR can be remove the |
Please continue reviewing my PR. Thanks. |
LGTM @ding @maixiaohai |
@fengberlin plz create a related issue~ |
I have been created the issue #698 related to this PR. |
Although the the resources associatd with the context created by context.WithTimeout will be release after the timer elapsed, but call cancel() to release the resources as soon as possible can avoid context/memory leak.