Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #662] Fix the usage bug of namespace #665

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

Git-Yang
Copy link
Member

@Git-Yang Git-Yang commented May 20, 2021

#662

What is the purpose of the change

  • 批量消息Namespace使用错误,需要对所有消息topic添加Namespace

Brief changelog

  • sendSync / sendAsync / sendOneWay 三个接口发送消息时,遍历所有msg,对topic添加Namespace

Verifying this change

By unit test

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@Git-Yang Git-Yang force-pushed the namespace_bug_fix branch from 124feb7 to 4f1c53c Compare May 20, 2021 03:10
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2021

Codecov Report

Merging #665 (3eb9052) into master (dfa26d1) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
+ Coverage   24.36%   24.51%   +0.15%     
==========================================
  Files          48       48              
  Lines        5204     5204              
==========================================
+ Hits         1268     1276       +8     
+ Misses       3726     3721       -5     
+ Partials      210      207       -3     
Impacted Files Coverage Δ
producer/producer.go 28.12% <100.00%> (+1.87%) ⬆️
producer/option.go 42.22% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfa26d1...3eb9052. Read the comment docs.

@Git-Yang Git-Yang force-pushed the namespace_bug_fix branch from 4f1c53c to 3eb9052 Compare May 20, 2021 07:00
@wenfengwang wenfengwang merged commit 673a8d0 into apache:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants