Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #621] Support consume message directly #622

Merged

Conversation

maixiaohai
Copy link
Contributor

What is the purpose of the change

issue #621

Brief changelog

Add func ConsumeMessageDirectly
Add unit test

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Mar 11, 2021

Codecov Report

Merging #622 (f91f448) into master (378f68a) will decrease coverage by 0.37%.
The diff coverage is 2.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   24.45%   24.08%   -0.38%     
==========================================
  Files          48       48              
  Lines        5050     5136      +86     
==========================================
+ Hits         1235     1237       +2     
- Misses       3612     3695      +83     
- Partials      203      204       +1     
Impacted Files Coverage Δ
consumer/push_consumer.go 10.82% <0.00%> (-0.57%) ⬇️
internal/client.go 0.00% <0.00%> (ø)
internal/request.go 1.88% <0.00%> (-0.22%) ⬇️
internal/model.go 43.67% <50.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 378f68a...f91f448. Read the comment docs.

@ShannonDing ShannonDing merged commit c97d492 into apache:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants