Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #596] Fix command register conflict, add consumer and producer logic code #597

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

maixiaohai
Copy link
Contributor

What is the purpose of the change

issue #596

Brief changelog

  1. Fix benchmark command register conflict
  2. Add code for producer and consumer to truly send and consume

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #597 (bd98b3e) into master (7e36c75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #597   +/-   ##
=======================================
  Coverage   24.29%   24.29%           
=======================================
  Files          48       48           
  Lines        5025     5025           
=======================================
  Hits         1221     1221           
  Misses       3604     3604           
  Partials      200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e36c75...bd98b3e. Read the comment docs.

@ShannonDing ShannonDing added bug Something isn't working test Unit Testing, Integration Testing labels Jan 28, 2021
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Unit Testing, Integration Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants