Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #585] Fix the wrong StoreHost and GroupName with consume trace message #586

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

maixiaohai
Copy link
Contributor

What is the purpose of the change

issue #585

Brief changelog

  1. Add ClientHost field and GroupName field to traceBean

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-io
Copy link

codecov-io commented Jan 10, 2021

Codecov Report

Merging #586 (fe7dba8) into master (f07155b) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   24.22%   24.34%   +0.12%     
==========================================
  Files          48       48              
  Lines        5011     5019       +8     
==========================================
+ Hits         1214     1222       +8     
  Misses       3598     3598              
  Partials      199      199              
Impacted Files Coverage Δ
internal/trace.go 29.60% <100.00%> (+2.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f07155b...fe7dba8. Read the comment docs.

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 15, 2021
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maixiaohai maixiaohai merged commit 9768869 into apache:master Jun 17, 2021
@maixiaohai maixiaohai linked an issue Jun 17, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Trace] [Enhancement] Add ClientHost and GroupName to tracebean
3 participants