Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default of SendResult.Status and fix panic #495

Merged
merged 2 commits into from
Jun 2, 2020

Conversation

dbl-x
Copy link
Contributor

@dbl-x dbl-x commented Jun 1, 2020

  1. set the default value of SendResult.Status to SendUnknownError
  2. fix panic: select queue with nil

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2020

Codecov Report

Merging #495 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #495      +/-   ##
==========================================
- Coverage   24.80%   24.76%   -0.04%     
==========================================
  Files          49       49              
  Lines        5716     5725       +9     
==========================================
  Hits         1418     1418              
- Misses       4095     4104       +9     
  Partials      203      203              
Impacted Files Coverage Δ
internal/trace.go 27.05% <0.00%> (-0.67%) ⬇️
primitive/result.go 0.00% <0.00%> (ø)
producer/producer.go 29.30% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba76ac6...d382bf3. Read the comment docs.

@ShannonDing ShannonDing added the bug Something isn't working label Jun 1, 2020
@ShannonDing ShannonDing added this to the 2.1.0 milestone Jun 1, 2020
Copy link
Member

@xujianhai666 xujianhai666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShannonDing ShannonDing merged commit 1fb7d33 into apache:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants