-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #999]support admin topicList and groupList method #1000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实现最好和java保持一致。
- 方法名GroupList 对应 getAllSubscriptionGroupadmin;TopicList 对应 fetchAllTopicList
- 通信层返回的RemotingCommand,admin这一层的返回值建议做成明确的struct
admin/admin.go
Outdated
GroupList(ctx context.Context, brokerAddr string) (*remote.RemotingCommand, error) | ||
TopicList(ctx context.Context) (*remote.RemotingCommand, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
实现最好和java保持一致。
- 方法名GroupList 对应 getAllSubscriptionGroupadmin;TopicList 对应 fetchAllTopicList
- 通信层返回的RemotingCommand,admin这一层的返回值建议做成明确的struct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOGT
What is the purpose of the change
#999
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.